OCPBUGS-62671: [release-4.18] Networking: reset ovn-remote config and allow ovnkube controller to set it #5325
Conversation
…et it This fixes the issue where ovn-remote is set prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB. This PR is part of the EIP GARP issue fix. Its required because when ovnkube-controller and ovn-controller container start on boot, there is no order to which container will start first, and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows. Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded syncing and the changes are available in SB DB. That maybe future work. Signed-off-by: Martin Kennelly <[email protected]> (cherry picked from commit 567a191) (cherry picked from commit 98291f7)
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci-robot
added
jira/severity-important
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-62671, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-with-prs 4.18 nightly blocking openshift/cluster-network-operator#2810 openshift/ovn-kubernetes#2775 |
|
@martinkennelly: trigger 10 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d396b30-9f8c-11f0-90d0-4678c9c2c425-0 |
|
@yuqi-zhang Thank you for reviewing the 4.20 PR - its not merged but we want the approvers lined up and labels added. Its a critical bug and we have the fastfix label applied. We will only merge when QE has verified. Its a clean cherry-pick. |
|
/approve And same comment as #5324 (comment) |
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
eurijon,
imatza-rh,
lyman9966,
mhanss,
ptalgulk01,
rbbratta,
rioliu-rh,
sergiordlr and
zhaozhanqi
openshift-ci
bot
added
the
approved
|
/payload-with-prs 4.18 nightly blocking openshift/cluster-network-operator#2810 openshift/ovn-kubernetes#2775 |
|
@martinkennelly: trigger 10 job(s) of type blocking for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1434b9a0-a43f-11f0-8a2f-32c75352f1ed-0 |
|
all required jobs passed and all the payloads passed. just for kicks I'll do a |
|
/payload-with-prs 4.18 ci blocking openshift/cluster-network-operator#2810 openshift/ovn-kubernetes#2775 |
openshift-ci-robot
added
the
verified
|
@jechen0648: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-with-prs 4.18 ci blocking openshift/cluster-network-operator#2810 openshift/ovn-kubernetes#2775 |
|
@jluhrsen: trigger 4 job(s) of type blocking for the ci release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da39e450-a54c-11f0-8e18-f1f75f4770a3-0 |
|
/test e2e-gcp-op-ocl |
|
CI blocking is good :) |
|
nightly blocking is good. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkennelly, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-gcp-op-ocl |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-62671, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/tide refresh |
|
active issue with hcp today: https://redhat-external.slack.com/archives/C01C8502FMM/p1760591559881549 |
|
/test e2e-hypershift |
|
/test e2e-hypershift New error for the hypershift job: |
|
Previous error discussed here: https://redhat-internal.slack.com/archives/CBN38N3MW/p1760617666933739 |
|
Should be fixed now |
|
/test e2e-hypershift Hyper shift job is unstable. Unrelated to this pr. Trying again |
|
/override ci/prow/e2e-hypershift This PR has passed hypershift on this commit before, failures are unrelated. Overriding. |
|
@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-hypershift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 86f5e90
into
openshift:release-4.18
|
@martinkennelly: Jira Issue OCPBUGS-62671: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-62671 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
16 participants
…et it
This fixes the issue where ovn-remote is set
prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB.
This PR is part of the EIP GARP issue fix.
Its required because when ovnkube-controller and
ovn-controller container start on boot, there
is no order to which container will start first,
and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows.
Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded
syncing and the changes are available in SB DB.
That maybe future work.
(cherry picked from commit 567a191) (cherry picked from commit 98291f7)
/hold
Depends on #5324